commit	4e3ba2dcbaddd32104b91690b2bde6a626bf3f51	[log] [tgz]
author	Dmitry Vyukov <dvyukov@google.com>	Sat Aug 10 18:35:40 2019 +0200
committer	Dmitry Vyukov <dvyukov@google.com>	Sat Aug 10 18:35:40 2019 +0200
tree	dc368db9d215c9914e296cad6c19ba12a5d7da7f
parent	7a5b4c58576630970ee3ea5db65097afda0d3cea [diff]

tree: dc368db9d215c9914e296cad6c19ba12a5d7da7f

README.md

README.md

Gerrit code reviews for the Linux kernel

Gerrit is a modern code review system that supports:

patch series
versioned changes (no need to explain what changed)
change tracking (what's your open changes/changes to review)
side-by-side diffs (shows added/removed parts within a line too)
full file context (you don't miss bugs on error paths)
base repository/revision (you can apply patches locally)
web-based rebase and editing files/commit message (for minor edits)
preserving comments across versions and comment threads

and more. Refer to the User Guide and Gerrit Docs for more info, but the information below should be enough to get you started.

The instance consists of a set of mirrors of kernel git repositories, which you can see and browse at linux.googlesource.com. Review changes can be created only for the mirrored repos. Currently two dozens of the most active repos are mirrored, but this list can be easily extended if there is interest.

The second part is the review system at linux-review.googlesource.com. All uploaded changes are public and visible to everyone, however creating own changes and participating in reviews requires a Google account. To sign in into the review system, click Sign in link in the top-right corner. Once you signed in you can see your outgoing, incoming and CCed changes at the dashboard.

Tutorial

To create a change for the net tree you need to:

clone the tree with:

git clone https://linux.googlesource.com/linux/kernel/git/davem/net

or add a new remote with:

git remote add -f gerrit-net https://linux.googlesource.com/linux/kernel/git/davem/net

Sign in into the gerrit instance using Sign in link in the top-right corner.
Click Generate Password link in the top menu. Copy-paste and execute the script which adds an auth cookie required for pushing changes for review.
Add gerrit commit hook to the git repo with:

(f=`git rev-parse --git-dir`/hooks/commit-msg; \
	mkdir -p $(dirname $f); \
	curl -Lo $f https://gerrit-review.googlesource.com/tools/hooks/commit-msg; \
	chmod +x $f)

The hook simply adds Change-Id: unique-id to commit messages, gerrit uses it to understand uploads of new versions of the same change.

Commit a change as usual:

git checkout gerrit-net/master
git checkout -b my-test-gerrit-change
sed -i "s#mm_init(#mem_init(#g" init/main.c
git commit -s --all -m "init: test change"

Push the change for review:

git push gerrit-net HEAD:refs/for/master

Pushing to the special path refs/for/target-branch creates a change based on the target-branch. The command output will contain the URL of the change, e.g.:

https://linux-review.googlesource.com/c/linux/kernel/git/davem/net/+/1109

you should also see it on the dashboard.

Push a new version:

sed -i "s#mem_init(#mem_initialize(#g" init/main.c
git commit --amend --all --no-edit
git push gerrit-net HEAD:refs/for/master

Gerrit knows it's a new version based on the Change-Id tag. Now you can see the new version at:

https://linux-review.googlesource.com/c/linux/kernel/git/davem/net/+/1109/2

as well as the diff between versions:

https://linux-review.googlesource.com/c/linux/kernel/git/davem/net/+/1109/1..2

To create patch series simply push a branch with multiple commits.