Fixes for 5.14-rc4:
 * Fix a number of coordination bugs relating to cache flushes for
   metadata writeback, cache flushes for multi-buffer log writes, and
   FUA writes for single-buffer log writes.
 * Fix a bug with incorrect replay of attr3 blocks.
 * Fix unnecessary stalls when flushing logs to disk.
 * Fix spoofing problems when recovering realtime bitmap blocks.
xfs: prevent spoofing of rtbitmap blocks when recovering buffers

While reviewing the buffer item recovery code, the thought occurred to
me: in V5 filesystems we use log sequence number (LSN) tracking to avoid
replaying older metadata updates against newer log items.  However, we
use the magic number of the ondisk buffer to find the LSN of the ondisk
metadata, which means that if an attacker can control the layout of the
realtime device precisely enough that the start of an rt bitmap block
matches the magic and UUID of some other kind of block, they can control
the purported LSN of that spoofed block and thereby break log replay.

Since realtime bitmap and summary blocks don't have headers at all, we
have no way to tell if a block really should be replayed.  The best we
can do is replay unconditionally and hope for the best.

Signed-off-by: Darrick J. Wong <>
Reviewed-by: Dave Chinner <>
Reviewed-by: Carlos Maiolino <>
1 file changed