)]}' { "commit": "da26adbf34821aeb7942cc432b18b0132aabfd4a", "tree": "f136e83fba4235d3e7a4201c01d8b5e796953a50", "parents": [ "6898c89d551f0d10fbdb68b9a57a71e4a2804428" ], "author": { "name": "Hugh Dickins", "email": "hughd@google.com", "time": "Wed Sep 04 05:02:44 2019 +0000" }, "committer": { "name": "Johannes Weiner", "email": "hannes@cmpxchg.org", "time": "Wed Sep 04 05:02:44 2019 +0000" }, "message": "tmpfs: fixups to use of the new mount API\n\nSeveral fixups to shmem_parse_param() and tmpfs use of new mount API:\n\nmm/shmem.c manages filesystem named \"tmpfs\": revert \"shmem\" to \"tmpfs\"\nin its mount error messages.\n\n/sys/kernel/mm/transparent_hugepage/shmem_enabled has valid options\n\"deny\" and \"force\", but they are not valid as tmpfs \"huge\" options.\n\nThe \"size\" param is an alternative to \"nr_blocks\", and needs to be\nrecognized as changing max_blocks. And where there\u0027s ambiguity, it\u0027s\nbetter to mention \"size\" than \"nr_blocks\" in messages, since \"size\" is\nthe variant shown in /proc/mounts.\n\nshmem_apply_options() left ctx-\u003empol as the new mpol, so then it was\nfreed in shmem_free_fc(), and the filesystem went on to use-after-free.\n\nshmem_parse_param() issue \"tmpfs: Bad value for \u0027%s\u0027\" messages just\nlike fs_parse() would, instead of a different wording. Where config\ndisables \"mpol\" or \"huge\", say \"tmpfs: Unsupported parameter \u0027%s\u0027\".\n\nLink: http://lkml.kernel.org/r/alpine.LSU.2.11.1908191503290.1253@eggly.anvils\nFixes: 144df3b288c41 (\"vfs: Convert ramfs, shmem, tmpfs, devtmpfs, rootfs to use the new mount API\")\nSigned-off-by: Hugh Dickins \u003chughd@google.com\u003e\nCc: David Howells \u003cdhowells@redhat.com\u003e\nCc: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "77d2df011c0eff4f6d9aa527fcf777d358e05342", "old_mode": 33188, "old_path": "mm/shmem.c", "new_id": "efc09c16fccfe0c1b22a67b3e2e09d054bb31182", "new_mode": 33188, "new_path": "mm/shmem.c" } ] }