)]}' { "commit": "34e3ab1447db13daad066bb9fcf76cb88a827da6", "tree": "af0c78665165dd21c32b015a3451ca88a3e3a61a", "parents": [ "d51b6b2287ae0c5432f03457a1dbc844e1968d12" ], "author": { "name": "Quentin Monnet", "email": "quentin@isovalent.com", "time": "Sat Oct 09 22:03:39 2021 +0100" }, "committer": { "name": "Andrii Nakryiko", "email": "andrii@kernel.org", "time": "Tue Oct 19 16:40:42 2021 -0700" }, "message": "bpftool: Fix install for libbpf\u0027s internal header(s)\n\nWe recently updated bpftool\u0027s Makefile to make it install the headers\nfrom libbpf, instead of pulling them directly from libbpf\u0027s directory.\nThere is also an additional header, internal to libbpf, that needs be\ninstalled. The way that bpftool\u0027s Makefile installs that particular\nheader is currently correct, but would break if we were to modify\n$(LIBBPF_INTERNAL_HDRS) to make it point to more than one header.\n\nUse a static pattern rule instead, so that the Makefile can withstand\nthe addition of other headers to install.\n\nThe objective is simply to make the Makefile more robust. It should\n_not_ be read as an invitation to import more internal headers from\nlibbpf into bpftool.\n\nFixes: f012ade10b34 (\"bpftool: Install libbpf headers instead of including the dir\")\nReported-by: Andrii Nakryiko \u003candrii@kernel.org\u003e\nSigned-off-by: Quentin Monnet \u003cquentin@isovalent.com\u003e\nSigned-off-by: Andrii Nakryiko \u003candrii@kernel.org\u003e\nAcked-by: John Fastabend \u003cjohn.fastabend@gmail.com\u003e\nLink: https://lore.kernel.org/bpf/20211009210341.6291-2-quentin@isovalent.com\n", "tree_diff": [ { "type": "modify", "old_id": "9c2d13c513f0eb6dd781b5ed3a7f7f1fba36890b", "old_mode": 33188, "old_path": "tools/bpf/bpftool/Makefile", "new_id": "646fd40b32533bd53d21da030df129cbafad012d", "new_mode": 33188, "new_path": "tools/bpf/bpftool/Makefile" } ] }