)]}'
{
  "commit": "564313447e545eea13038f74ada9272ab129b3cb",
  "tree": "56b23214027a9e531e9da706e66658aa3105547f",
  "parents": [
    "b4aac29a21d96974ae6e6d8e7b1b01e1f95c4348"
  ],
  "author": {
    "name": "Yongjian Wang",
    "email": "echoowall@gmail.com",
    "time": "Mon Oct 26 15:23:09 2026 +0800"
  },
  "committer": {
    "name": "Jakub Kicinski",
    "email": "kuba@kernel.org",
    "time": "Wed Oct 28 15:51:38 2026 -0700"
  },
  "message": "Revert \"net: advertise TCP MSS from the configured MTU, not the learned PMTU\"\n\nThis reverts commit 2640e6419594 (\"net: advertise TCP MSS from the\nconfigured MTU, not the learned PMTU\").\n\nThat commit stopped the learned PMTU from lowering the MSS we advertise\nin SYN and SYN-ACK. For symmetric paths it argued that \"the peer runs\nits own PMTU discovery and usually already knows the real path MTU\".\nThat only holds if ICMP \"fragmentation needed\" can reach the peer. When\nthe peer sits behind a firewall that drops inbound ICMP, its PMTU\ndiscovery is a black hole (RFC 2923, section 2.1), and the smaller MSS\nwe advertised was the only thing keeping its full-size segments off the\nnarrow hop.\n\nInbound ICMP filtering is very common in enterprise and carrier\nnetworks, and it is pervasive in mainland China. We hit this in\nproduction after the commit was backported to 6.12.111: TCP connections\nthat reach a server through a relay with a smaller-MTU hop complete the\nhandshake, then stall as soon as the client sends full-size segments.\nClients on networks that let ICMP through, and connections that bypass\nthe relay, are unaffected, which made it hard to trace back to the\nkernel.\n\nReproducer, network namespaces on a single host:\n\n  cli --(1500)-- r1 --(1456)-- r2 --(1500)-- srv\n\nr1 drops ICMP frag-needed towards cli. srv has already learned PMTU\n1456 towards cli, then cli uploads 1 MB to srv:\n\n  kernel                     SYN-ACK MSS   1 MB upload\n  6.12.107                   1416          OK\n  6.12.111                   1460          stalls, times out\n  7.3-rc7                    1460          stalls, times out\n  7.3-rc7 + this revert      1416          OK\n\nThe asymmetric case the commit was written for does not need a new\ndefault: the advertised MSS can already be set per route with the\nadvmss metric, which takes precedence over default_advmss(). With this\nrevert applied, on an asymmetric path where srv learned PMTU 1456\ntowards cli while cli-\u003esrv is 1500 end to end:\n\n  srv route to cli           SYN-ACK MSS   largest cli-\u003esrv segment\n  default                    1416          1404\n  advmss 1460                1460          1448\n\nSo DSR-style setups can opt in with \"ip route ... advmss \u003cmss\u003e\", while\nhosts whose peers cannot complete PMTU discovery keep working by\ndefault.\n\nFixes: 2640e6419594 (\"net: advertise TCP MSS from the configured MTU, not the learned PMTU\")\nCloses: https://lore.kernel.org/regressions/4F0FAEB6-A13B-47F3-BFF1-C706686C6F64@gmail.com/\nCc: stable@vger.kernel.org\nSigned-off-by: Yongjian Wang \u003cechoowall@gmail.com\u003e\nReviewed-by: Eric Dumazet \u003cedumazet@kernel.org\u003e\nReviewed-by: Jiayuan Chen \u003cjiayuan.chen@linux.dev\u003e\nLink: https://patch.msgid.link/20261026-advmss-revert-v1-2-272fa4b7ecb6@gmail.com\nSigned-off-by: Jakub Kicinski \u003ckuba@kernel.org\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "618b9806c10b0a272b4dfa7420a17de375c4b4a6",
      "old_mode": 33188,
      "old_path": "include/net/ip.h",
      "new_id": "0acc4ba5e5b340886ac2ec726ebab31c795b9af9",
      "new_mode": 33188,
      "new_path": "include/net/ip.h"
    },
    {
      "type": "modify",
      "old_id": "5f47cef0be469e08849d524daa066192647190f7",
      "old_mode": 33188,
      "old_path": "include/net/ip6_route.h",
      "new_id": "95f936be32c6ccdf3b845b5a431f3cd545d983dd",
      "new_mode": 33188,
      "new_path": "include/net/ip6_route.h"
    },
    {
      "type": "modify",
      "old_id": "595a3b7f1783009417da80545db5d3360bd2ffd2",
      "old_mode": 33188,
      "old_path": "net/ipv4/route.c",
      "new_id": "93b9f418952574cf0d142782299063753b0f8778",
      "new_mode": 33188,
      "new_path": "net/ipv4/route.c"
    },
    {
      "type": "modify",
      "old_id": "94e5ef1c4f83e745158c047f46efdd61038e6db1",
      "old_mode": 33188,
      "old_path": "net/ipv6/route.c",
      "new_id": "5760a357e6e7f6c5da35fa1a42168369cadc6553",
      "new_mode": 33188,
      "new_path": "net/ipv6/route.c"
    }
  ]
}
