)]}'
{
  "commit": "cc993e0927ec8bd98ea33377ada03295fcda0f24",
  "tree": "ef9508726d04cb2d21d40db919b6ca633e191bbd",
  "parents": [
    "98d0912e9f841e5529a5b89a972805f34cb1c69d"
  ],
  "author": {
    "name": "Chuck Lever",
    "email": "chuck.lever@oracle.com",
    "time": "Mon May 25 12:51:15 2026 -0400"
  },
  "committer": {
    "name": "Paolo Abeni",
    "email": "pabeni@redhat.com",
    "time": "Thu May 28 13:35:31 2026 +0200"
  },
  "message": "net/handshake: Use spin_lock_bh for hn_lock\n\nnvmet_tcp_state_change(), a socket callback that runs in BH context,\ncan reach handshake_req_cancel() via nvmet_tcp_schedule_release_queue()\nand tls_handshake_cancel().  handshake_req_cancel() acquires\nhn-\u003ehn_lock with plain spin_lock().  If a process-context thread on\nthe same CPU holds hn-\u003ehn_lock when a softirq invokes the cancel path,\nthe lock attempt deadlocks.  This is the only caller that invokes\ntls_handshake_cancel() from BH context; every other consumer calls it\nfrom process context.\n\nDeferring the cancel to process context in the NVMe target is not\nstraightforward: nvmet_tcp_schedule_release_queue() must call\ntls_handshake_cancel() atomically with its state transition to\nDISCONNECTING.  If the cancel were deferred, the handshake completion\ncallback could fire in the window before the cancel runs, observe the\nunexpected state, and return without dropping its kref on the queue.\nReworking that interlock is considerably more invasive than hardening\nthe handshake lock.  Convert all hn-\u003ehn_lock acquisitions from\nspin_lock/spin_unlock to spin_lock_bh/spin_unlock_bh so the lock is\nnever taken with softirqs enabled.\n\nFixes: 675b453e0241 (\"nvmet-tcp: enable TLS handshake upcall\")\nSigned-off-by: Chuck Lever \u003cchuck.lever@oracle.com\u003e\nReviewed-by: Hannes Reinecke \u003chare@kernel.org\u003e\nLink: https://patch.msgid.link/20260525-handshake-file-pin-v3-1-66c616906ead@oracle.com\nSigned-off-by: Paolo Abeni \u003cpabeni@redhat.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "b989456fc4c5ff28ccc782775c918fc01d6b620e",
      "old_mode": 33188,
      "old_path": "net/handshake/netlink.c",
      "new_id": "97114ec8027a5a1594a3130d89da97ebfdf2429d",
      "new_mode": 33188,
      "new_path": "net/handshake/netlink.c"
    },
    {
      "type": "modify",
      "old_id": "2829adbeb149b083e73e4d6ac4bcb35b065fb2e4",
      "old_mode": 33188,
      "old_path": "net/handshake/request.c",
      "new_id": "5d4a17f902d201cdcc356f41ab453c35ba79aad5",
      "new_mode": 33188,
      "new_path": "net/handshake/request.c"
    },
    {
      "type": "modify",
      "old_id": "8f9532a15f43f9ee7ffcb96568811c580afcd771",
      "old_mode": 33188,
      "old_path": "net/handshake/tlshd.c",
      "new_id": "af294c6cc717313cb5deb66d2e4cd9ffa288284d",
      "new_mode": 33188,
      "new_path": "net/handshake/tlshd.c"
    }
  ]
}