| commit | c04de0c79534ec03c3efa49b72a90a55851b2c25 | [log] [tgz] |
|---|---|---|
| author | Eric Dumazet <edumazet@google.com> | Thu Dec 18 08:18:44 2025 +0000 |
| committer | Paolo Abeni <pabeni@redhat.com> | Sun Dec 28 10:19:11 2025 +0100 |
| tree | 979874c9a8161bf4eee469cde8203bfd6a041048 | |
| parent | f79f9b7ace1713e4b83888c385f5f55519dfb687 [diff] |
net: avoid prefetching NULL pointers
Aditya Gupta reported PowerPC crashes bisected to the blamed commit.
Apparently some platforms do not allow prefetch() on arbitrary pointers.
prefetch(next);
prefetch(&next->priority); // CRASH when next == NULL
Only NULL seems to be supported, with specific handling in prefetch().
Add a conditional to avoid the two prefetches and the skb->next clearing
for the last skb in the list.
Fixes: b2e9821cff6c ("net: prefech skb->priority in __dev_xmit_skb()")
Reported-by: Aditya Gupta <adityag@linux.ibm.com>
Closes: https://lore.kernel.org/netdev/e9f4abee-b132-440f-a50e-bced0868b5a7@linux.ibm.com/T/#mddc372b64ec5a3b181acc9ee3909110c391cc18a
Signed-off-by: Eric Dumazet <edumazet@google.com>
Tested-by: Aditya Gupta <adityag@linux.ibm.com>
Link: https://patch.msgid.link/20251218081844.809008-1-edumazet@google.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>