commit ea47ab111669b187808b3080602788dec26cb9bc
author Al Viro <viro@zeniv.linux.org.uk> Tue Sep 07 16:14:05 2021 -0400
committer Al Viro <viro@zeniv.linux.org.uk> Tue Sep 07 16:14:05 2021 -0400
tree db4f163675e6f72f3a9f59d5509f4e8b80b903c9
parent b4a4f213a39d5e55baf38c96042acaeaf927ec74

putname(): IS_ERR_OR_NULL() is wrong here

Mixing NULL and ERR_PTR() just in case is a Bad Idea(tm).  For
struct filename the former is wrong - failures are reported
as ERR_PTR(...), not as NULL.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

fs/namei.c

diff --git a/fs/namei.c b/fs/namei.c
index bbb5c9b..1946d96 100644
--- a/fs/namei.c
+++ b/fs/namei.c
@@ -255,7 +255,7 @@ getname_kernel(const char * filename)
 
 void putname(struct filename *name)
 {
-	if (IS_ERR_OR_NULL(name))
+	if (IS_ERR(name))
 		return;
 
 	BUG_ON(name->refcnt <= 0);