commit ee5ea1c51d72ece3c52946ae9a03f4e37f16cea6
author Denis Efremov <efremov@linux.com> Wed Sep 04 05:02:51 2019 +0000
committer Johannes Weiner <hannes@cmpxchg.org> Wed Sep 04 05:02:51 2019 +0000
tree 40a6b8bd2602f010153bb92d74f2294926aa0e51
parent 873a690015a30bb0f217b792b35aa9f3c741b352

fs: remove unlikely() from WARN_ON() condition

"unlikely(WARN_ON(x))" is excessive. WARN_ON() already uses unlikely()
internally.

Link: http://lkml.kernel.org/r/20190829165025.15750-5-efremov@linux.com
Signed-off-by: Denis Efremov <efremov@linux.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: Joe Perches <joe@perches.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

fs/open.c

diff --git a/fs/open.c b/fs/open.c
index c60cd22..b62f5c0 100644
--- a/fs/open.c
+++ b/fs/open.c
@@ -776,7 +776,7 @@
 		f->f_mode |= FMODE_ATOMIC_POS;
 
 	f->f_op = fops_get(inode->i_fop);
-	if (unlikely(WARN_ON(!f->f_op))) {
+	if (WARN_ON(!f->f_op)) {
 		error = -ENODEV;
 		goto cleanup_all;
 	}